[MRELEASE-1145] Upgrade to Maven 3.6.3 #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested review from
cstamas,
slawekjaranowski,
slachiewicz and
gnodet
7 tasks
|
Amy opinion on the modified code? Otherwise I will update piece by piece and merge next couple of days. |
Does the getter change makes sense? |
|
For me does, as I explained you when showed the gist: https://gist.github.com/cstamas/b847b879a0ca072c8cdc2aac4f2ce797 You are not interested in full transitive hull, you release this current project (but you need to get resolved versions if ranges are used). |
This closes #217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cstamas Please have a sharp look before I continue upgrading. I am not 100% certain that my fix is correct.